{testsdk} Include azure.cli.testsdk.scenario_tests in wheel#20698
Merged
{testsdk} Include azure.cli.testsdk.scenario_tests in wheel#20698
azure.cli.testsdk.scenario_tests in wheel#20698Conversation
azure.cli.testsdk.scenario_tests in wheelazure.cli.testsdk.scenario_tests in wheel
evelyn-ys
approved these changes
Dec 13, 2021
kairu-ms
approved these changes
Dec 13, 2021
zhoxing-ms
approved these changes
Dec 13, 2021
Contributor
zhoxing-ms
left a comment
There was a problem hiding this comment.
Just out of curiosity, may I ask why azure.cli.testsdk.scenario_tests is not included in azure.cli.testsdk?
Member
Author
Simply because it is not defined in azure-cli/src/azure-cli/setup.py Line 179 in 4e4539d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After
azure-devtools's code toazure-cli-testsdk#20601CI fails:
https://dev.azure.com/azure-sdk/public/_build/results?buildId=1244125&view=logs&jobId=c846b3e8-69b8-5dbd-1a39-4905d81e6a95&j=c846b3e8-69b8-5dbd-1a39-4905d81e6a95&t=9ebb608a-8a51-5834-bad0-46e2c03d2282
This is because
azure.cli.testsdk.scenario_testsis missing from the built wheel.Adding it to
setup.py.