[Core] Use optimistic locking for service principal entry reads#20408
Merged
[Core] Use optimistic locking for service principal entry reads#20408
Conversation
15d2714 to
c9a48e2
Compare
rayluo
approved these changes
Nov 18, 2021
Collaborator
|
Auth |
yonzhan
approved these changes
Nov 18, 2021
calvinhzy
approved these changes
Nov 19, 2021
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
evelyn-ys
approved these changes
Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fix #20273 (fix for MSAL token cache is done by AzureAD/microsoft-authentication-extensions-for-python#100)
Ported from AzureAD/microsoft-authentication-extensions-for-python#100
Context
Sometimes, read operation is slow. This can be simulated by inserting
statements before
azure-cli/src/azure-cli-core/azure/cli/core/auth/persistence.py
Line 66 in 1f560eb
In such case, concurrent reads can lead to exception:
Change
This PR ports the change from AzureAD/microsoft-authentication-extensions-for-python#100 to use optimistic locking for service principal entry reads.
Concurrent reads now won't trigger any exception.
Testing Guide