{Core} Optimize performance for MSAL migration #19898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
commented
Oct 15, 2021
Comment on lines
+105
to
+109
| # Importing azure.core.credentials.AccessToken is expensive. | ||
| # This can slow down commands that doesn't need azure.core, like `az account get-access-token`. | ||
| # So We define our own AccessToken. | ||
| from collections import namedtuple | ||
| AccessToken = namedtuple("AccessToken", ["token", "expires_on"]) |
There was a problem hiding this comment.
This can eliminate the Azure Core import time:
python -X importtime -m azure.cli account get-access-token 2>perf.log; tuna .\perf.log
# Before
> Measure-Command {python -m azure.cli account get-access-token}
TotalMilliseconds : 1281.14
# After
> Measure-Command {python -m azure.cli account get-access-token}
TotalMilliseconds : 1070.6358
|
performance Optimization |
evelyn-ys
approved these changes
Oct 15, 2021
evelyn-ys
approved these changes
Oct 15, 2021
evelyn-ys
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As authentication logic is now split from
Profile, performance can be further improved by lazy loading.auth.identitymodule.Imported modules can be inspected with