Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Oct 8, 2021

Description

It has been nearly a year since we deprecated creating Contributor role assignment by default (#16081). It is time to officially remove this behavior.

Testing Guide

az ad sp create-for-rbac
az ad sp create-for-rbac --role Reader

@jiasli jiasli requested a review from evelyn-ys as a code owner October 8, 2021 07:20
@jiasli jiasli requested a review from yonzhan October 8, 2021 07:20
@yonzhan yonzhan added this to the Oct 2021 (2021-11-02) milestone Oct 8, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Oct 8, 2021

Role

@jiasli jiasli marked this pull request as draft November 9, 2021 05:37
@jiasli jiasli marked this pull request as ready for review December 9, 2021 09:39
@jiasli jiasli requested a review from calvinhzy as a code owner December 9, 2021 09:39
Copy link
Contributor

@chasewilson chasewilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

help='Skip creating the default assignment, which allows the service principal to access resources under the current subscription. '
'When specified, --scopes will be ignored. You may use `az role assignment create` to create '
'role assignments for this service principal later.')
deprecate_info=c.deprecate(target='--skip-assignment', hide=True), help='No-op.')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--skip-assignment is now a no-op argument to keep the command backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants