{Upgrade} Download MSI to a local file first #19192
Conversation
jiasli
requested review from
Juliehzl,
evelyn-ys,
jsntcy,
kairu-ms and
zhoxing-ms
as code owners
heaths
left a comment
heaths
left a comment
There was a problem hiding this comment.
A couple nits, but overall LGTM. Thanks!
| Directly installing from URL may be blocked by policy: https://github.com/Azure/azure-cli/issues/19171 | ||
| This also gives the user a chance to manually install the MSI in case of msiexec.exe failure. | ||
| """ | ||
| logger.warning("Updating Azure CLI with MSI from https://aka.ms/installazurecliwindows") |
There was a problem hiding this comment.
This was logger.debug before. Intentional change?
There was a problem hiding this comment.
Yes.
I want the command to be more explicit and give the user more information about what it is doing internally. Otherwise, in case of failure, all that the user can see is CLI upgrade failed. (No different from Something occurred.)
To view the details, the user must specify --debug which is definitely not user-friendly.
| import tempfile | ||
| tmp_dir = tempfile.mkdtemp() | ||
| msi_path = os.path.join(tmp_dir, file_name) | ||
| logger.warning("Downloading MSI to %s", msi_path) |
There was a problem hiding this comment.
Similarly, isn't this more of a logger.debug?
| "or run 'pip install --upgrade azure-cli' in this container") | ||
| elif installer == 'MSI': | ||
| logger.debug("Update azure cli with MSI from https://aka.ms/installazurecliwindows") | ||
| exit_code = subprocess.call(['powershell.exe', '-NoProfile', "Start-Process msiexec.exe -Wait -ArgumentList '/i https://aka.ms/installazurecliwindows'"]) # pylint: disable=line-too-long |
There was a problem hiding this comment.
There is no need to launch PowerShell and let it launch msiexec.exe. Directly launching msiexec.exe is sufficient.
5 participants
Symptom
Fix #19171, #18566
Directly installing from URL may be blocked by policy: #19171. The exact reason for the failure is unclear, and installing MSI from a URL is always problematic.
Change
Download MSI to a temp folder and install it with
msiexec.exe. This also gives the user a chance to manually install the MSI in case ofmsiexec.exefailure.Testing Guide
In
upgrade_version, after retrieving theinstaller:azure-cli/src/azure-cli/azure/cli/command_modules/util/custom.py
Line 62 in c100b80
force
so that
_upgrade_on_windowscan be triggered.