{EventGrid} - Fix delivery-identity, delivery-endpoint-type and delivery-identity-endpoint #18900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
EventGrid |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
Can you add tests for In reply to: 885374697 |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
evelyn-ys
reviewed
Jul 26, 2021
Comment on lines
+687
to
+688
| self.kwargs['source_resource_id'] = self.cmd('storage account create -g {rg} -n {sa} --sku Standard_LRS -l {location}').get_output_in_json()['id'] | ||
| self.cmd('az storage account update -g {rg} -n {sa} --set kind=StorageV2') |
Member
There was a problem hiding this comment.
Suggested change
| self.kwargs['source_resource_id'] = self.cmd('storage account create -g {rg} -n {sa} --sku Standard_LRS -l {location}').get_output_in_json()['id'] | |
| self.cmd('az storage account update -g {rg} -n {sa} --set kind=StorageV2') | |
| self.kwargs['source_resource_id'] = self.cmd('storage account create -g {rg} -n {sa} --sku Standard_LRS --kind StorageV2 -l {location}').get_output_in_json()['id'] | |
| ``` #Pending |
Contributor
Author
There was a problem hiding this comment.
i think the issue is we can't create with the right kind hence done in 2 steps..
evelyn-ys
reviewed
Jul 26, 2021
Comment on lines
+673
to
+674
| @ResourceGroupPreparer(name_prefix='clieventgrid', location='centraluseuap') | ||
| @StorageAccountPreparer(name_prefix='clieventgrid', location='centraluseuap') |
Member
There was a problem hiding this comment.
Suggested change
| @ResourceGroupPreparer(name_prefix='clieventgrid', location='centraluseuap') | |
| @StorageAccountPreparer(name_prefix='clieventgrid', location='centraluseuap') | |
| @ResourceGroupPreparer(name_prefix='clieventgrid', location='centraluseuap') |
@StorageAccountPreparer is not needed here since you created manually below.
evelyn-ys
reviewed
Jul 26, 2021
| self.check('provisioningState', 'Succeeded'), | ||
| ]) | ||
|
|
||
| self.cmd('az eventgrid event-subscription delete --source-resource-id {source_resource_id} --name {event_subscription_name}') |
Member
There was a problem hiding this comment.
Suggested change
| self.cmd('az eventgrid event-subscription delete --source-resource-id {source_resource_id} --name {event_subscription_name}') | |
| self.cmd('az eventgrid event-subscription delete --source-resource-id {source_resource_id} --name {event_subscription_name}') | |
| self.cmd('az storage account delete --ids {source_resource_id} -y') |
Don't forget to clear storage account resource~
Member
|
redirect to #18989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
az eventgrid event-subscription update --name --source-resource-id --delivery-identity-endpoint-type eventhub --delivery-identity systemassigned --delivery-identity-endpoint
az eventgrid systemtopic event-subscription update --name --source-resource-id --delivery-identity-endpoint-type eventhub --delivery-identity systemassigned --delivery-identity-endpoint
az eventgrid partner event-subscription update --name --source-resource-id --delivery-identity-endpoint-type eventhub --delivery-identity systemassigned --delivery-identity-endpoint