[AppService] Fix get resource management client properly #18142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l cause ResourceManagementClient to use latest version of python SDK automatically, instead of using version controlled by core cli
Collaborator
|
AppService |
detienne20
pushed a commit
to detienne20/azure-cli
that referenced
this pull request
May 20, 2021
Juliehzl
approved these changes
May 20, 2021
zhoxing-ms
approved these changes
May 20, 2021
qwordy
approved these changes
May 20, 2021
zhoxing-ms
pushed a commit
that referenced
this pull request
May 21, 2021
…GA (05/04) (#17869) * Initial draft for formUiDefinition * Tested with generated SDK from Azure/sdk-release-request#1469 * TemplateSpecsVersion parameters artifacts and template have been replaced by linked_templates and main_template * Restored new lined at end of launch.json file * reverting changes to setup.py until sdk release * TemplateSpecs regression addressed #17733 (comment) * Customer reported bug fix * Removed _packing_engine changes * Re-recorded test cases with template specs * Reviewer suggestion * Re-recorded template specs tests live * Fixed CLI Style * Merged with dev * Removed merge conflicts * Removed merge conflicts * Restored new line for launch.json * Restored new lines at end of files * Bump template specs SDK to latest release * Tested with new SDK * Deployments Tests with new SDK * SDK Bump to 18.0.0 * Tracking Linux requirements * Merged with dev and added changes from #18142 * Rerecord test_nw_connection_monitor_v2_creation Co-authored-by: Tarun Sunkaraneni <[email protected]> Co-authored-by: Dania Etienne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Importing
ResourceManagementClientincorrectly causes it to use latest version of python SDK automatically, instead of the version specified by core CLIThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.