Skip to content

{Pylint} Fix self-assigning-variable #18119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 2 commits into from
May 25, 2021
Merged

{Pylint} Fix self-assigning-variable #18119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66b318d
self-assigning-variable
jiasli May 18, 2021
4cbc5ec
unused-argument
jiasli May 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ disable=
no-member,
no-value-for-parameter,
raise-missing-from,
self-assigning-variable,
subprocess-run-check,
super-with-arguments,
too-many-arguments,
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli/azure/cli/command_modules/servicefabric/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1880,7 +1880,6 @@ def _set_parameters_for_customize_template(cmd,
certificate_subject_name,
secret_identifier,
parameter_file):
cli_ctx = cli_ctx
parameters = get_file_json(parameter_file)['parameters']
if parameters is None:
raise CLIError('Invalid parameters file')
Expand Down
5 changes: 1 addition & 4 deletions src/azure-cli/azure/cli/command_modules/sqlvm/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,13 +127,10 @@ def sqlvm_group_update(instance, domain_fqdn=None, cluster_operator_account=None
def sqlvm_aglistener_create(client, cmd, availability_group_listener_name, sql_virtual_machine_group_name,
resource_group_name, availability_group_name, ip_address, subnet_resource_id,
load_balancer_resource_id, probe_port, sql_virtual_machine_instances, port=1433,
public_ip_address_resource_id=None, vnet_name=None):
public_ip_address_resource_id=None, vnet_name=None): # pylint: disable=unused-argument
Copy link
Member

@qwordy qwordy May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If vnet_name is not used, can we remove it?

Copy link
Member Author

@jiasli jiasli May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove it, it will be a break change to the upper-level command az sql vm group ag-listener create as --vnet-name will be removed. I only fix the linter error, so prefer not to change it.

'''
Creates an availability group listener
'''
# Not using vnet, just for validation
vnet_name = vnet_name

# Create the private ip address
private_ip_object = PrivateIPAddress(ip_address=ip_address,
subnet_resource_id=subnet_resource_id
Expand Down
1 change: 0 additions & 1 deletion src/azure-cli/azure/cli/command_modules/synapse/operations/spark.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ def create_spark_batch_job(cmd, workspace_name, spark_pool_name, job_name, main_
file = main_definition_file
class_name = main_class_name
arguments = command_line_arguments
configuration = configuration
# dotnet spark
if language.upper() == SparkBatchLanguage.SparkDotNet.upper() or language.upper() == SparkBatchLanguage.CSharp.upper():
file = DOTNET_FILE
Expand Down