{Batch} Add account key and SAS signature replacers for tests #18004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpwatrous
requested review from
bgklein,
gingi,
paterasMSFT and
qwordy
as code owners
Collaborator
|
Batch |
dpwatrous
force-pushed
the
dpwatrous/batch-key-replacer
branch
from
0266698 to
43e16fb
Compare
Member
Author
|
Updated the PR to include an SAS replacer to (hopefully) get around CredScan issues. |
dpwatrous
changed the title
gingi
approved these changes
May 7, 2021
Member
gingi
left a comment
gingi
left a comment
There was a problem hiding this comment.
Looks great. Not to be that guy but in the Python script you're mixing both single quotes and double quotes. Not a big deal.
qwordy
approved these changes
May 10, 2021
Member
Author
|
@qwordy Thanks for the quick approval - this is all set to merge as far as I'm concerned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a scrubber for account keys and SAS signatures. The previous keys were not live, so there is no security issue, but this change replaces them with obviously fake values (ie: "fakeBatchAccountKey0==")
Testing Guide
Run the batch unit tests with the new recordings
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.