Burtbiel/required params #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaeunYim
added a commit
to DaeunYim/azure-cli
that referenced
this pull request
Sep 12, 2020
VNET integration for Flexible Servers
sturrent
added a commit
to sturrent/azure-cli
that referenced
this pull request
Oct 21, 2025
Three critical bugs were discovered and fixed that prevented User-Defined Route (UDR) analysis from functioning in the integrated CLI command: Bug Azure#17: RouteTableAnalyzer Not Integrated - RouteTableAnalyzer was copied but never instantiated in orchestrator - Added Phase 3 for route table analysis - Renumbered all phases from 1/8-8/8 to 1/9-9/9 - Embedded route_table_analysis into outbound_analysis['udr_analysis'] - Updated report_generator to accept route_table_analysis parameter Bug Azure#18: Route Table Field Case Sensitivity - Added dual checking for both 'vnetSubnetId' and 'vnet_subnet_id' - Ensures compatibility with different SDK data sources - Handles camelCase/snake_case variations robustly Bug Azure#19: Wrong Dictionary Key for Network Client - Fixed clients.get('network') → clients.get('network_client') - RouteTableAnalyzer was receiving None instead of NetworkManagementClient - This was the critical blocker preventing subnet lookups Testing Results: - aks-overlay cluster now correctly detects UDR with firewall route - Warning generated: "Default route (0.0.0.0/0) redirects all internet traffic through virtual appliance at 192.168.11.1" - Route table 'sec-udr' found and analyzed - Virtual appliance routes properly categorized Files Modified: - orchestrator.py: Added RouteTableAnalyzer integration, fixed client key - route_table_analyzer.py: Added dual-case field checking - report_generator.py: Added route_table_analysis parameter - PHASE6-PROGRESS.md: Documented all three bugs Impact: UDR analysis now fully functional, critical networking configurations are properly detected and reported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required params take the format:
@option('--foo -f ', _('fake'), required=True)