[KeyVault] BREAKING CHANGE: Support soft-delete feature for managed-HSM. keyvault delete --hsm-name will perform soft delete on a MHSM.
#17834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houk-ms
requested review from
Juliehzl,
evelyn-ys,
fengzhou-msft,
jiasli,
jsntcy,
qwordy and
yungezz
as code owners
houk-ms
commented
Apr 23, 2021
| try: | ||
| result = poller.result() | ||
| except ClientException as client_exception: | ||
| except (ClientException, HttpResponseError) as client_exception: |
Contributor
Author
There was a problem hiding this comment.
We will handle the case in anothor PR #17833
houk-ms
commented
Apr 23, 2021
houk-ms
commented
Apr 23, 2021
| raise CLIError('No deleted Vault or HSM was found with name ' + resource_name) | ||
|
|
||
| if 'keyvault purge' not in cmd.name: | ||
| if 'keyvault purge' not in cmd.name and 'keyvault show-deleted' not in cmd.name: |
Contributor
Author
There was a problem hiding this comment.
these two comands won't need resource-group parameter
houk-ms
changed the title
keyvault delete --hsm-name will soft delete not permanently delete a HSM.keyvault delete --hsm-name will soft delete not permanently delete a MHSM.
houk-ms
commented
Apr 23, 2021
|
|
||
|
|
||
| class KeyVaultHSMMgmtScenarioTest(ScenarioTest): | ||
| @record_only() |
Contributor
Author
There was a problem hiding this comment.
Make this test can be lively runned.
Member
|
this is not a CLI interface breaking, but service behavior change, right? |
yungezz
approved these changes
Apr 25, 2021
Contributor
Author
Yes, this is a service side breaking change. |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
It is not a correct English sentence. |
houk-ms
changed the title
keyvault delete --hsm-name will soft delete not permanently delete a MHSM.keyvault delete --hsm-name will perform soft delete on a MHSM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR supports the soft-delete feature for managed-HSM
The new added commands and parameters include
az keyvault show-deletedcommand--resource-type hsmparameter for commandaz keyvault list-deleted--hsm-nameparameter for commandaz keyvault purgeThe following command's behavior changes
az keyvault delete --hsm-nameIt soft deletes a mhsm not permanently delete it. For permanently delete casse we provide the command
az keyvault purge --hsm-name.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.