Skip to content

{Packaging} Include *.ipynb file when packaging#17704

Merged
evelyn-ys merged 3 commits intoAzure:devfrom
evelyn-ys:synapse_fix
Apr 19, 2021
Merged

{Packaging} Include *.ipynb file when packaging#17704
evelyn-ys merged 3 commits intoAzure:devfrom
evelyn-ys:synapse_fix

Conversation

@evelyn-ys
Copy link
Member

Description

Synapse's test: test_notebook fails in L1164 in CI Full Test

def test_notebook(self):
self.kwargs.update({
'workspace': 'testsynapseworkspace',
'name': 'notebook',
'spark-pool': 'testpool',
'file': os.path.join(os.path.join(os.path.dirname(__file__), 'assets'), 'notebook.ipynb')
})
# create notebook
self.cmd(
'az synapse notebook create --workspace-name {workspace} --name {name} --file @"{file}" '
'--spark-pool-name {spark-pool}',
checks=[
self.check('name', self.kwargs['name'])
])

The error msg shows:

InvalidArgumentValueError: Failed to parse JSON: @/usr/lib64/az/lib/python3.6/site-packages/azure/cli/command_modules/synapse/tests/latest/assets/notebook.ipynb

It might caused because .ipynb file was not packaged in full test. This PR aims to fix it.


This checklist is used to make sure that common guidelines for a pull request are followed.

@evelyn-ys evelyn-ys requested a review from jiasli as a code owner April 15, 2021 06:58
@evelyn-ys evelyn-ys self-assigned this Apr 15, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 15, 2021

packaging

@yonzhan yonzhan added this to the S186 milestone Apr 15, 2021
@evelyn-ys evelyn-ys merged commit 79cffd3 into Azure:dev Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants