Conversation
Contributor
Author
|
cc: @Francisco-Gamino @AnatoliB @pragnagopa @gzuber Please review this PR. Thanks! |
yungezz
approved these changes
Apr 14, 2021
qwordy
approved these changes
Apr 14, 2021
pragnagopa
reviewed
Apr 14, 2021
| }, | ||
| "isPreview": false, | ||
| "isDeprecated": false, | ||
| "isHidden": false |
Member
There was a problem hiding this comment.
We want this stack to be hidden until we roll out functions host changes to support linux consumption
pragnagopa
suggested changes
Apr 14, 2021
Member
pragnagopa
left a comment
pragnagopa
left a comment
There was a problem hiding this comment.
Please add stack as hidden. Also, need to add tests that check powershell stack
Member
Hey @stefanushinardi I sent you a message about the tests, let me know if I can help out! 😄 |
added 2 commits
April 15, 2021 17:01
Contributor
Author
|
@pragnagopa @gzuber Added that tests for powershell. Thanks @Hazhzeng to help fix the local setip |
Member
|
@stefanushinardi Are we ready to merge? |
pragnagopa
approved these changes
Apr 16, 2021
Contributor
Author
|
@qwordy yup, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR is to add Powershell on linux offerings #17657
Testing Guide
Verified that now the command does not throw validation error when deploying with Linux os type. And also verified creation of both consumption and elastic premium plan
sample command:
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.