Skip to content

[ARM] az bicep: Replace datetime APIs that are not available in Python 3.6 #17675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoxing-ms merged 1 commit into from
Apr 14, 2021
Merged

[ARM] az bicep: Replace datetime APIs that are not available in Python 3.6 #17675

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/azure-cli/azure/cli/command_modules/resource/_bicep.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
_bicep_installation_dir = os.path.join(_config_dir, "bin")
_bicep_version_check_file_path = os.path.join(_config_dir, "bicepVersionCheck.json")
_bicep_version_check_cache_ttl = timedelta(minutes=10)
_bicep_version_check_time_format = "%Y-%m-%dT%H:%M:%S.%f"

_logger = get_logger(__name__)

Expand Down Expand Up @@ -149,7 +150,7 @@ def _load_bicep_version_check_result_from_cache():
with open(_bicep_version_check_file_path, "r") as version_check_file:
version_check_data = json.load(version_check_file)
latest_release_tag = version_check_data["latestReleaseTag"]
last_check_time = datetime.fromisoformat(version_check_data["lastCheckTime"])
last_check_time = datetime.strptime(version_check_data["lastCheckTime"], _bicep_version_check_time_format)
cache_expired = datetime.now() - last_check_time > _bicep_version_check_cache_ttl

return latest_release_tag, cache_expired
Expand All @@ -160,7 +161,7 @@ def _load_bicep_version_check_result_from_cache():
def _refresh_bicep_version_check_cache(lastest_release_tag):
with open(_bicep_version_check_file_path, "w+") as version_check_file:
version_check_data = {
"lastCheckTime": datetime.now().isoformat(timespec="microseconds"),
"lastCheckTime": datetime.now().strftime(_bicep_version_check_time_format),
"latestReleaseTag": lastest_release_tag,
}
json.dump(version_check_data, version_check_file)
Expand Down