Skip to content

[Compute] vm create --count mode, support vnet and subnet configuration #17660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qwordy merged 3 commits into from
Apr 15, 2021
Merged

[Compute] vm create --count mode, support vnet and subnet configuration #17660

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e9827b2
[Compute] vm create --count mode, support vnet and subnet configuration
qwordy Apr 13, 2021
d40dad9
Merge branch 'dev' of https://github.com/Azure/azure-cli into 17649
qwordy Apr 15, 2021
225b004
17649
qwordy Apr 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/azure-cli/azure/cli/command_modules/vm/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1766,7 +1766,8 @@ def _validate_vmss_create_host_group(cmd, namespace):

def _validate_count(namespace):
if namespace.count < 2 or namespace.count > 250:
raise ValidationError('--count should be in [2, 250]')
raise ValidationError(
'--count should be in [2, 250]. Please make sure your subscription has enough quota of resources')
banned_params = [
namespace.attach_data_disks,
namespace.attach_os_disk,
Expand All @@ -1781,9 +1782,7 @@ def _validate_count(namespace):
namespace.public_ip_address_dns_name,
namespace.storage_account,
namespace.storage_container_name,
namespace.subnet,

@houk-ms houk-ms Apr 14, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we remove it here?

@qwordy qwordy Apr 14, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I disabled it. Now I decide to enable it.

@qwordy qwordy Apr 14, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17217

namespace.use_unmanaged_disk,
namespace.vnet_name
]
params_str = [
'--attach-data-disks',
Expand Down