Skip to content

Conversation

@Jing-song
Copy link
Contributor

@Jing-song Jing-song commented Apr 9, 2021

Description

Fix #16579
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost
Copy link

ghost commented Apr 9, 2021

CLA assistant check
All CLA requirements met.

jiasli
jiasli previously requested changes Apr 9, 2021
@fengzhou-msft
Copy link
Member

@PARADISSEEKR Please catch the exceptions in telemetry.py for the purpose of fixing the mentioned issue, do not change error handling in core/_profile.py.

@fengzhou-msft fengzhou-msft changed the title [Telemetry] Fix issue 16579 {Telemetry} Fix issue 16579 Apr 9, 2021
@fengzhou-msft
Copy link
Member

Changed the title as it's not customer-facing. See Format PR Title.

@Jing-song Jing-song closed this Apr 12, 2021
@Jing-song Jing-song deleted the jingsong/16579 branch April 12, 2021 02:40
@Jing-song Jing-song restored the jingsong/16579 branch April 12, 2021 04:08
@Jing-song Jing-song reopened this Apr 12, 2021
move the except logic to telemetry.
This reverts commit 9e8ffbc.
Modify the code style and make it conforms to the rules
@Jing-song Jing-song changed the title {Telemetry} Fix issue 16579 {Telemetry} Fix issue 16579 Suppress telemetry exception in --debug when there is no valid account login Apr 12, 2021
Modify the code style and make it conforms to the rules
@fengzhou-msft fengzhou-msft changed the title {Telemetry} Fix issue 16579 Suppress telemetry exception in --debug when there is no valid account login {Telemetry} Fix #16579: Suppress telemetry exception in --debug when there is no valid account login Apr 13, 2021
@jiasli jiasli dismissed their stale review April 13, 2021 07:43

cancel

@fengzhou-msft fengzhou-msft merged commit 9a030e0 into Azure:dev Apr 13, 2021
@Jing-song Jing-song deleted the jingsong/16579 branch April 14, 2021 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Telemetry reports issue when there is no valid account login

4 participants