Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Apr 9, 2021

Description

Temporary fix for #17625.

Starting from azure-core 1.13.0, Authorization header is now exposed in DEBUG log (Azure/azure-sdk-for-python#17424).

Temporarily pin azure-core to 1.12.0 so that Authorization header is redacted.

Testing Guide

az storage account list --debug

'argcomplete~=1.8',
'azure-cli-telemetry==1.0.6.*',
'azure-common~=1.1',
'azure-core==1.12.0',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also do this in setup.py so that CLI installed with pip will also only use azure-core==1.12.0.

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 9, 2021

Packaging

@yonzhan yonzhan added this to the S186 milestone Apr 9, 2021
@jiasli jiasli merged commit 44efe87 into Azure:dev Apr 12, 2021
@jiasli jiasli deleted the azure-core branch April 12, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants