{Network} Network support extendedLocation #17623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-extendedlocation-2021-04-07
Collaborator
|
Network |
qwordy
approved these changes
Apr 19, 2021
Juliehzl
reviewed
Apr 19, 2021
| help='Space-separated list of availability zones into which to provision the resource.', | ||
| choices=['1', '2', '3'] | ||
| ) | ||
| edge_zone = CLIArgumentType(help='The name of edge zone.', is_preview=True, min_api='2020-08-01') |
Contributor
There was a problem hiding this comment.
You could use this type for edge zone and add min_api version for your parameter
kairu-ms
reviewed
Apr 20, 2021
| vnet_help = "Name or ID of an existing virtual network which has a subnet named 'GatewaySubnet'." | ||
| c.argument('virtual_network', options_list='--vnet', help=vnet_help) | ||
| c.argument('vpn_gateway_generation', arg_type=get_enum_type(['Generation1', 'Generation2']), min_api='2019-07-01', help='The generation for the virtual network gateway. vpn_gateway_generation should not be provided if gateway_type is not Vpn.') | ||
| c.ignore('edge_zone') # wait for service ready |
Contributor
There was a problem hiding this comment.
Do you need to expose this parameter as service not ready?
Member
Author
There was a problem hiding this comment.
'az network vnet-gateway create' need new swagger : https://github.com/Azure/azure-rest-api-specs/pull/13864/files
(RE: virtualNetworkGateway missing extendedLocation in swagger)
Member
Author
There was a problem hiding this comment.
It is ignored. So customers could not use it.
Contributor
There was a problem hiding this comment.
It is ignored. So customers could not use it.
I think customer can see it in command help message. Why not expose it when service is ready?
kairu-ms
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar link:
storage : #17528
compute: #17522
'az network vnet-gateway create' need new swagger : https://github.com/Azure/azure-rest-api-specs/pull/13864/files
(RE: virtualNetworkGateway missing extendedLocation in swagger)
Testing Guide
NetworkExtendedLocation
History Notes
[Network]
az network lb create: Add new parameter--edge-zone[Network]
az network nic create: Add new parameter--edge-zone[Network]
az network private-endpoint create: Add new parameter--edge-zone[Network]
az network private-link-service create: Add new parameter--edge-zone[Network]
az network public-ip create: Add new parameter--edge-zone[Network]
az network public-ip prefix create: Add new parameter--edge-zone[Network]
az network vnet create: Add new parameter--edge-zoneThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.