{Telemetry} Add telemetry info of extension even when install fail #17609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msyyc
approved these changes
Apr 8, 2021
fengzhou-msft
commented
Apr 8, 2021
Member
Author
There was a problem hiding this comment.
version may be None, the information will be overwritten if the extension is resolved from index. If before that, the command exits, then the information set here can be useful.
fengzhou-msft
force-pushed
the
add_telemetry_when_extension_install_fail
branch
from
5dd85b0 to
bf61c81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Existing code will only add
Context.Default.AzureCLI.ExtensionManagementDetailafter the extension is installed. This PR extracts extension name and version from source url and add to telemetry so that these data will be sent by telemetry even when the install of extension fails.Testing Guide
In a virtual env, downgrade pip:
python -m pip -U pip==18.0.Run
az extension add -s https://azurecliext.blob.core.windows.net/release/azure_cli_ml-1.21.0-py3-none-any.whl -y.The install will fail, check the telemetry record in
~/.azure/telemetry/cache, you should see"Context.Default.AzureCLI.ExtensionManagementDetail": "[email protected]".History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.