Skip to content

Conversation

@hiaga
Copy link
Member

@hiaga hiaga commented Apr 5, 2021

Description

Fixed policy create with rgNamePrefix and rgNameSuffix. https://portal.microsofticm.com/imp/v3/incidents/details/233746722/home

Testing Guide

az backup policy create --name "TestingPolicy" --resource-group "MABRG02" --vault-name "vault410" --backup-management-type "AzureIaasVM" --policy "testpolicy.json"

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@qwordy qwordy changed the title fixed policy create with rgNamePrefix and rgNameSuffix [Backup] fixed policy create with rgNamePrefix and rgNameSuffix Apr 6, 2021
@qwordy
Copy link
Member

qwordy commented Apr 6, 2021

@hiaga Some checks were not successful

Results 
=========


ERROR: /home/vsts/work/1/s/src/azure-cli/azure/cli/command_modules/backup/custom.py:277:1: E302 expected 2 blank lines, found 1
/home/vsts/work/1/s/src/azure-cli/azure/cli/command_modules/backup/custom.py:281:1: W293 blank line contains whitespace
/home/vsts/work/1/s/src/azure-cli/azure/cli/command_modules/backup/custom.py:288:1: E302 expected 2 blank lines, found 1
/home/vsts/work/1/s/src/azure-cli/azure/cli/command_modules/backup/custom.py:277:1: E302 expected 2 blank lines, found 1
/home/vsts/work/1/s/src/azure-cli/azure/cli/command_modules/backup/custom.py:281:1: W293 blank line contains whitespace
/home/vsts/work/1/s/src/azure-cli/azure/cli/command_modules/backup/custom.py:288:1: E302 expected 2 blank lines, found 1
4     E302 expected 2 blank lines, found 1
2     W293 blank line contains whitespace

ERROR: Flake8: FAILED

ERROR: ************* Module azure.cli.command_modules.backup.custom
src/azure-cli/azure/cli/command_modules/backup/custom.py:281:0: C0303: Trailing whitespace (trailing-whitespace)
src/azure-cli/azure/cli/command_modules/backup/custom.py:281:0: C0303: Trailing whitespace (trailing-whitespace)

@hiaga hiaga force-pushed the hiaga/policyCreate branch from aebe640 to 20c0ca4 Compare April 6, 2021 03:42
@hiaga
Copy link
Member Author

hiaga commented Apr 6, 2021

@qwordy all checks have passed

@qwordy qwordy merged commit 9c8554c into Azure:dev Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants