Skip to content

[Compute] az ssh vm: Support VM SSH with Service Principal #17554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jiasli merged 1 commit into from
Apr 8, 2021
Merged

[Compute] az ssh vm: Support VM SSH with Service Principal #17554

jiasli merged 1 commit into from
Apr 8, 2021

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Apr 2, 2021

Description

Close #17521

Changes

  • Return a certificate correctly when the current account (az account show) is a Service Principal account.
  • Create ServicePrincipalCredential class that extends msal.ConfidentialClientApplication and exposes get_token API.

Testing Guide

az login --service-principal --username <sp_id> --password <secret_or_cert> --tenant <tenant_id>
az ssh vm -g <rg_name> --vm-name <vm_name> --debug

@jiasli jiasli self-assigned this Apr 2, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 2, 2021

Compute

@yonzhan yonzhan added this to the S185 milestone Apr 2, 2021
@jiasli jiasli marked this pull request as ready for review April 7, 2021 06:39
SanDeo-MSFT
SanDeo-MSFT approved these changes Apr 7, 2021
View reviewed changes
Copy link

@SanDeo-MSFT SanDeo-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have installed the edge build and have verified that the Service Principal auth based SSH login works.

@jiasli jiasli merged commit 2fcf0b0 into Azure:dev Apr 8, 2021
@jiasli jiasli deleted the sp-ssh branch April 8, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rayluo rayluo Awaiting requested review from rayluo

@evelyn-ys evelyn-ys Awaiting requested review from evelyn-ys evelyn-ys is a code owner

@houk-ms houk-ms Awaiting requested review from houk-ms

@jsntcy jsntcy Awaiting requested review from jsntcy jsntcy is a code owner

@Juliehzl Juliehzl Awaiting requested review from Juliehzl

2 more reviewers

@SanDeo-MSFT SanDeo-MSFT SanDeo-MSFT approved these changes

@fengzhou-msft fengzhou-msft fengzhou-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jiasli jiasli

Labels

None yet

Projects

None yet

Milestone

S185

Development

Successfully merging this pull request may close these issues.

[Compute] Support getting VM SSH certificate with Service Principal credential

4 participants

@jiasli @yonzhan @SanDeo-MSFT @fengzhou-msft