Skip to content

Conversation

@BigCat20196
Copy link
Contributor

@BigCat20196 BigCat20196 commented Apr 2, 2021

Description

Resolve #17461
{KeyVault} Adds two examples for the az keyvault seret set command to prompt users how to use the command.
Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

az keyvault secret set --name MySecretName --vault-name MyKeyVault --value MyVault
- name: Create a secret (if one doesn't exist) or update a secret in a KeyVault.(Through a file)
text: |
az keyvault secret set --name MySecretName --file MyFilePath --encoding MyEncoding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use something like /path/to/file for --file example value.

- name: Create a secret (if one doesn't exist) or update a secret in a KeyVault.
text: |
az keyvault secret set --name MySecretName --vault-name MyKeyVault --value MyVault
- name: Create a secret (if one doesn't exist) or update a secret in a KeyVault.(Through a file)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Create a secret (if one doesn't exist) or update a secret in a KeyVault.(Through a file)
- name: Create a secret (if one doesn't exist) or update a secret in a KeyVault through a file.

@fengzhou-msft fengzhou-msft self-requested a review April 2, 2021 08:03
@fengzhou-msft
Copy link
Member

Please take a look at the linter error. You can run with azdev linter keyvault locally.

@fengzhou-msft fengzhou-msft changed the title {KeyVault}Fix #17461 Add some examples for 'keyvault/_help.py' {KeyVault} Fix #17461: Add some examples for 'keyvault/_help.py' Apr 2, 2021
@yungezz yungezz added the KeyVault az keyvault label Apr 6, 2021
@BigCat20196 BigCat20196 merged commit 64847ce into Azure:dev Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

KeyVault az keyvault

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Value should be set as required

4 participants