[Compute] New command: vm install-patches #17549

xfz11 · 2021-04-02T05:13:28Z

Description

New command vm install-patches
Resolve #16790

Example
az vm install-patches -g MyResourceGroup -n MyVm --maximum-duration PT4H --reboot-setting IfRequired --classifications-to-include Critical Security --exclude-kbs-requiring-reboot true

Testing Guide

        self.cmd(
            'vm create -g {rg} -n vm --image Win2019Datacenter --enable-hotpatching true --admin-username azureuser --admin-password testPassword0 --nsg-rule NONE')
        self.cmd('vm install-patches -g {rg} -n vm --maximum-duration PT4H --reboot-setting IfRequired '
                 '--classifications-to-include Critical Security --exclude-kbs-requiring-reboot true', checks=[
            self.check('status', 'Succeeded')
        ])

History Notes

This checklist is used to make sure that common guidelines for a pull request are followed.

The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.

qwordy · 2021-04-02T05:18:37Z

I suggest develop features in your own forked repository.

src/azure-cli/azure/cli/command_modules/vm/_actions.py

src/azure-cli/azure/cli/command_modules/vm/_params.py

src/azure-cli/azure/cli/command_modules/vm/custom.py

src/azure-cli/azure/cli/command_modules/vm/_params.py

src/azure-cli/azure/cli/command_modules/vm/custom.py

src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py

src/azure-cli/azure/cli/command_modules/vm/_help.py

src/azure-cli-core/azure/cli/core/profiles/_shared.py

src/azure-cli/azure/cli/command_modules/vm/_params.py

src/azure-cli/azure/cli/command_modules/vm/custom.py

src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py

src/azure-cli/azure/cli/command_modules/vm/commands.py

src/azure-cli-core/azure/cli/core/profiles/_shared.py

xfz11 · 2021-04-08T02:21:13Z

/azp run

azure-pipelines · 2021-04-08T02:21:25Z

Azure Pipelines successfully started running 2 pipeline(s).

xfz11 · 2021-04-08T08:17:41Z

/azp run

azure-pipelines · 2021-04-08T08:17:55Z

Azure Pipelines successfully started running 2 pipeline(s).

xfz11 · 2021-04-08T09:41:40Z

/azp run

azure-pipelines · 2021-04-08T09:41:55Z

Azure Pipelines successfully started running 2 pipeline(s).

xfz11 · 2021-04-09T00:20:19Z

/azp run

azure-pipelines · 2021-04-09T00:20:32Z

Azure Pipelines successfully started running 2 pipeline(s).

update install-patches test case update as comments lint update test recording add test case Update src/azure-cli-core/azure/cli/core/profiles/_shared.py Co-authored-by: Feiyue Yu <[email protected]> Update src/azure-cli/azure/cli/command_modules/vm/_params.py Co-authored-by: Feiyue Yu <[email protected]> Update src/azure-cli/azure/cli/command_modules/vm/custom.py Co-authored-by: Feiyue Yu <[email protected]> update as comments Update src/azure-cli/azure/cli/command_modules/vm/custom.py Co-authored-by: Feiyue Yu <[email protected]> update as comments update add client in the arguments list of install_vm_patches function remove short name of arguments disable option_length_too_long lint remove unnecessary comma refactor arguments lint lint option_length_too_long add help info

xfz11 requested review from houk-ms and qwordy April 2, 2021 05:13

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/_actions.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/_params.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/_params.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/_params.py Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 2, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/_help.py Outdated Show resolved Hide resolved

yungezz assigned qwordy Apr 6, 2021

yungezz added the Compute az vm/vmss/image/disk/snapshot label Apr 6, 2021

qwordy reviewed Apr 6, 2021

View reviewed changes

src/azure-cli-core/azure/cli/core/profiles/_shared.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 6, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/_params.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 6, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 6, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 6, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 6, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 6, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

xfz11 marked this pull request as ready for review April 6, 2021 09:34

xfz11 requested review from evelyn-ys, fengzhou-msft, jiasli and jsntcy as code owners April 6, 2021 09:34

xfz11 requested review from Juliehzl and yungezz as code owners April 6, 2021 09:34

qwordy reviewed Apr 7, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 7, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/custom.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 7, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/tests/latest/test_vm_commands.py Show resolved Hide resolved

qwordy reviewed Apr 7, 2021

View reviewed changes

src/azure-cli/azure/cli/command_modules/vm/commands.py Outdated Show resolved Hide resolved

qwordy reviewed Apr 7, 2021

View reviewed changes

src/azure-cli-core/azure/cli/core/profiles/_shared.py Outdated Show resolved Hide resolved

qwordy approved these changes Apr 8, 2021

View reviewed changes

xfz11 force-pushed the issue16790 branch from 88f05d7 to a6c0b86 Compare April 8, 2021 08:33

xfz11 force-pushed the issue16790 branch from a6c0b86 to 3a5091e Compare April 9, 2021 01:39

xfz11 merged commit 3b813cb into dev Apr 9, 2021

jiasli deleted the issue16790 branch August 5, 2021 02:54

[Compute] New command: vm install-patches #17549

[Compute] New command: vm install-patches #17549

Uh oh!

Conversation

xfz11 commented Apr 2, 2021

Uh oh!

qwordy commented Apr 2, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

xfz11 commented Apr 8, 2021

Uh oh!

azure-pipelines bot commented Apr 8, 2021

Uh oh!

xfz11 commented Apr 8, 2021

Uh oh!

azure-pipelines bot commented Apr 8, 2021

Uh oh!

xfz11 commented Apr 8, 2021

Uh oh!

azure-pipelines bot commented Apr 8, 2021

Uh oh!

xfz11 commented Apr 9, 2021

Uh oh!

azure-pipelines bot commented Apr 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants