Skip to content

Conversation

@calvinsID
Copy link
Contributor

Description
In some apps with only single publish profile, API doesn't return a list andaz webapp deployment source config-zip breaks

Testing Guide
Run az webapp deployment source config-zip on a webapp that only has a single publish profile, the command will error out.
The behaviour will not be changed if the webapp has multiple publish profiles


This checklist is used to make sure that common guidelines for a pull request are followed.

@calvinsID calvinsID added this to the S185 milestone Mar 29, 2021
@calvinsID calvinsID changed the title [AppService] Handle if only single publish profile is returned [AppService] Bugfix: Handle if only single publish profile is returned Mar 29, 2021
@calvinsID calvinsID force-pushed the fix-webapp-publish-profile branch from 7a8ae12 to ce8fe56 Compare March 29, 2021 18:28
Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - do we need to re-record any tests?

@yungezz yungezz added the Web Apps az webapp label Apr 1, 2021
@qwordy
Copy link
Member

qwordy commented Apr 6, 2021

@calvinsID

ERROR: /home/vsts/work/1/s/src/azure-cli/azure/cli/command_modules/appservice/custom.py:1059:5: F841 local variable 'e' is assigned to but never used
/home/vsts/work/1/s/src/azure-cli/azure/cli/command_modules/appservice/custom.py:1059:5: F841 local variable 'e' is assigned to but never used
2     F841 local variable 'e' is assigned to but never used

ERROR: Flake8: FAILED

ERROR: ************* Module azure.cli.command_modules.appservice.custom
src/azure-cli/azure/cli/command_modules/appservice/custom.py:1059:4: W0612: Unused variable 'e' (unused-variable)
src/azure-cli/azure/cli/command_modules/appservice/custom.py:1059:4: W0612: Unused variable 'e' (unused-variable)

@qwordy qwordy merged commit 8aa6d18 into Azure:dev Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Web Apps az webapp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants