[Container] Fix #16499: az container create: fix handling of return value from network_profiles.create_or_update #17486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes issue 16499
The implementation of 'az container create' is expecting the wrong return value from NetworkProfilesOperations.create_or_update().
NetworkProfilesOperations.create_or_update() is documented here:
https://docs.microsoft.com/en-us/python/api/azure-mgmt-network/azure.mgmt.network.v2020_06_01.operations.networkprofilesoperations?view=azure-python#create-or-update-resource-group-name--network-profile-name--parameters----kwargs-
Testing Guide
As described in issue 16499, run a command similar to the following using an empty resource group:
az container create --registry-username reguser --location eastus --registry-password regpassword --name container-name --resource-group container-resource-group --image image:tag --vnet container-vnet --vnet-address-prefix 192.168.0.0/16 --subnet container-subnet 192.168.0.0/24 --subnet-address-prefix 10.0.0.0/24The command will fail the first time it is run because the azure-cli is expecting a different return value. The command will create the vnet, subnet, and network profile before failing. This allows the command to succeed the second time it is run.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.