Skip to content

Conversation

@markrzasa
Copy link
Contributor

@markrzasa markrzasa commented Mar 28, 2021

Description

This pull request fixes issue 16499

The implementation of 'az container create' is expecting the wrong return value from NetworkProfilesOperations.create_or_update().

NetworkProfilesOperations.create_or_update() is documented here:

https://docs.microsoft.com/en-us/python/api/azure-mgmt-network/azure.mgmt.network.v2020_06_01.operations.networkprofilesoperations?view=azure-python#create-or-update-resource-group-name--network-profile-name--parameters----kwargs-

Testing Guide

As described in issue 16499, run a command similar to the following using an empty resource group:

az container create --registry-username reguser --location eastus --registry-password regpassword --name container-name --resource-group container-resource-group --image image:tag --vnet container-vnet --vnet-address-prefix 192.168.0.0/16 --subnet container-subnet 192.168.0.0/24 --subnet-address-prefix 10.0.0.0/24

The command will fail the first time it is run because the azure-cli is expecting a different return value. The command will create the vnet, subnet, and network profile before failing. This allows the command to succeed the second time it is run.


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Mar 28, 2021
@ghost
Copy link

ghost commented Mar 28, 2021

Thank you for your contribution markrzasa! We will review the pull request and get back to you soon.

@markrzasa
Copy link
Contributor Author

markrzasa commented Apr 6, 2021

HI Everyone,

Is there anything I can do to help get this change approved? Maybe there's something I've missed?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Container Instances az container customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants