Skip to content

Conversation

@kairu-ms
Copy link
Contributor

Description

Testing Guide

History Notes

[Monitor] Add new command az monitor metrics list-namespaces


This checklist is used to make sure that common guidelines for a pull request are followed.

@kairu-ms kairu-ms requested review from jsntcy and msyyc as code owners March 26, 2021 06:48
@kairu-ms kairu-ms changed the title [Monitor] Azure Monitor Essentials 100% depth [Monitor] Azure Monitor Essentials 100% depth Support Mar 26, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 26, 2021

Monitor

@yonzhan yonzhan added this to the S185 milestone Mar 26, 2021
return _generic_table_convert(results, row_convert)


def metrics_namespaces_table(results):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need the transform?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default metricNamespaceName will not show as a table column because it's the second level property.

Copy link
Member

@ToddKingMSFT ToddKingMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the example documentation, why do we have a placeholder for subscription id but resource group and the resource name have real values?
/subscriptions/{subscriptionID}/resourceGroups/Space1999/providers/Microsoft.Network/networkSecurityGroups/ADDS-NSG
It seems like it should be consistent like
/subscriptions/{subscriptionID}/resourceGroups/{resourceGroup}/Microsoft.Network/networkSecurityGroups/{resourceName}

@kairu-ms
Copy link
Contributor Author

kairu-ms commented Apr 1, 2021

In the example documentation, why do we have a placeholder for subscription id but resource group and the resource name have real values?
/subscriptions/{subscriptionID}/resourceGroups/Space1999/providers/Microsoft.Network/networkSecurityGroups/ADDS-NSG
It seems like it should be consistent like
/subscriptions/{subscriptionID}/resourceGroups/{resourceGroup}/Microsoft.Network/networkSecurityGroups/{resourceName}

I will fix it. Thanks.

@yonzhan yonzhan modified the milestones: S185, S186 Apr 10, 2021
@kairu-ms kairu-ms merged commit cfcc104 into Azure:dev Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants