Skip to content

[Network] express route 100% depth support.#17450

Merged
kairu-ms merged 6 commits intoAzure:devfrom
kairu-ms:feature-expressroute-deeps-20210325
Apr 12, 2021
Merged

[Network] express route 100% depth support.#17450
kairu-ms merged 6 commits intoAzure:devfrom
kairu-ms:feature-expressroute-deeps-20210325

Conversation

@kairu-ms
Copy link
Contributor

@kairu-ms kairu-ms commented Mar 25, 2021

Description

Testing Guide

History Notes

[Network] New command az network express-route list-route-tables-summary.
[Network] New command az network express-route peering get-stats.
[Network] New command az network express-route peering connection list.


This checklist is used to make sure that common guidelines for a pull request are followed.

@kairu-ms kairu-ms requested review from jsntcy and msyyc as code owners March 25, 2021 08:13
@yonzhan yonzhan added this to the S185 milestone Mar 25, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 25, 2021

Network

@jiasli
Copy link
Member

jiasli commented Mar 26, 2021

- deeps
+ depth

@kairu-ms kairu-ms changed the title [Network] express route 100% deeps support. [Network] express route 100% depth support. Mar 26, 2021
@jsntcy jsntcy requested a review from 00Kai0 March 26, 2021 03:06
c.argument('peer_circuit', help='Name or ID of the peer ExpressRoute circuit.', validator=validate_er_peer_circuit)

with self.argument_context('network express-route peering connection list') as c:
c.argument('circuit_name', id_part=None)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is 'id_part=None' needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we are not suppose to add --ids argument for list and create commands.

@yonzhan yonzhan modified the milestones: S185, S186 Apr 10, 2021
@kairu-ms kairu-ms merged commit 0c697e5 into Azure:dev Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants