[Service Fabric] Add managed application cli commands #17404
Conversation
|
/azp run |
|
Commenter does not have sufficient privileges for PR 17404 in repo Azure/azure-cli |
|
@qwordy The pipeline failures dont seem to be directly related to the changes i've made here. Any ideas? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
@LukeSlev Failure of "Test Extensions Loading Python36" is fixed. Let's retry. You may need to pull from dev branch and push. |
LukeSlev
force-pushed
the
user/luslevin/managed-applications
branch
from
3a70095 to
c4817e2
Compare
|
@qwordy I rebased on dev and checks seem to be passing, should be ready for a review |
|
@qwordy I see you're the assigned reviewer, do you have any comments on the PR? |
| namespace.primary_default_load is None or namespace.secondary_default_load is None: | ||
| raise CLIError("--metric-name, --weight, --primary-default-load and --secondary-default-load are required") | ||
| if namespace.default_load is not None: | ||
| raise CLIError("--default-load can only be used for stateless services.") |
There was a problem hiding this comment.
I recommend to use ValidationError instead of CLIError. Definition is in src/azure-cli-core/azure/cli/core/azclierror.py.
There was a problem hiding this comment.
Ok, I changed those
|
@LukeSlev Did you write these code manually? I know a package that can generate CLI code. https://www.npmjs.com/package/@autorest/az |
I did write it manually, I wasn't aware of that package. Thanks for letting me know, we will look into using it in the future |
|
@qwordy Made your suggested change |
2 participants
Description
These cmdlets will support a New offering (resource type) - Service Fabric managed clusters for our customers. In this new model, Service Fabric resource provider (SFRP) manages the entire resource group for the essential components of the cluster, including VMSS, VNet/Load Balancer and storage account for diagnostics and bootstrap. These commands are to support the creation and management applications, applicationtypes, applicationtypeversions and services on the new service fabric managed clusters.
Testing Guide
see src\azure-cli\azure\cli\command_modules\servicefabric_help.py for examples and descriptions
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.