Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Mar 22, 2021

Description

As nosttests has actually been deprecated (the repo https://github.com/nose-devs/nose hasn't been updated since 2016), the full test should be moved to azdev and pytest.

Known issues

@jiasli jiasli requested a review from fengzhou-msft as a code owner March 22, 2021 05:24
@jiasli jiasli marked this pull request as draft March 22, 2021 05:25
@yonzhan yonzhan added this to the S185 milestone Mar 22, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 22, 2021

CI

@yonzhan yonzhan requested a review from msyyc March 22, 2021 05:29
@jiasli jiasli marked this pull request as ready for review March 26, 2021 08:28
@jiasli jiasli requested a review from qwordy March 29, 2021 05:56
displayName: Automation Test (Profile Latest)
timeoutInMinutes: 120
pool:
vmImage: 'ubuntu-16.04'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is 16.04 too old? Consider 18.04 or 20.04

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will update in #17368 to keep in sync with main pipeline.

Comment on lines +41 to +44
Python36:
python.version: '3.6'
Python38:
python.version: '3.8'
Copy link
Member

@qwordy qwordy Apr 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is 3.7? Is 3.7 less important than 3.6 or 3.8?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We package with Python 3.6 and currently we support up to 3.8. @fengzhou-msft

profile: ''
- name: pythonVersion
type: string
default: ''
Copy link
Member

@qwordy qwordy Apr 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does '' mean? How about setting default value 3.8?

Copy link
Member Author

@jiasli jiasli Apr 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does '' mean?

'' means empty string. I copied it as-is. It also appears here:

- name: CLIExtensionRepoPath
type: string
default: ''

How about setting default value 3.8?

Sure.

@jiasli jiasli merged commit bf08c94 into Azure:dev Apr 6, 2021
@jiasli jiasli deleted the full-test branch April 6, 2021 08:50
@jiasli jiasli mentioned this pull request May 11, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants