-
Notifications
You must be signed in to change notification settings - Fork 3.3k
{CI} Use azdev and pytest for full test
#17383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CI |
| displayName: Automation Test (Profile Latest) | ||
| timeoutInMinutes: 120 | ||
| pool: | ||
| vmImage: 'ubuntu-16.04' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 16.04 too old? Consider 18.04 or 20.04
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update in #17368 to keep in sync with main pipeline.
| Python36: | ||
| python.version: '3.6' | ||
| Python38: | ||
| python.version: '3.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is 3.7? Is 3.7 less important than 3.6 or 3.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We package with Python 3.6 and currently we support up to 3.8. @fengzhou-msft
| profile: '' | ||
| - name: pythonVersion | ||
| type: string | ||
| default: '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does '' mean? How about setting default value 3.8?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does '' mean?
'' means empty string. I copied it as-is. It also appears here:
azure-cli/.azure-pipelines/templates/azdev_setup.yml
Lines 5 to 7 in 0fa1fb5
| - name: CLIExtensionRepoPath | |
| type: string | |
| default: '' |
How about setting default value 3.8?
Sure.
Description
As
nosttestshas actually been deprecated (the repo https://github.com/nose-devs/nose hasn't been updated since 2016), the full test should be moved toazdevandpytest.Known issues
azure-cli/scripts/ci/test_automation.sh
Lines 23 to 24 in e7186c8
azdevcallspytestto run tests sequentially. This causes the pipeline running time to double compared to that ofnosttests.