{Misc} Fix broken Cloud Shell link #17291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Misc |
jiasli
commented
Mar 12, 2021
README.md
Outdated
| Take a test run now from Azure Cloud Shell! | ||
|
|
||
| [](https://shell.azure.com) | ||
| Take a test run now from [Azure Cloud Shell](https://portal.azure.com/#cloudshell/)! |
Member
Author
There was a problem hiding this comment.
https://shell.azure.com now redirects to https://portal.azure.com/#cloudshell/
> curl --include https://shell.azure.com
HTTP/1.1 301 Moved Permanently
Content-Length: 160
Content-Type: text/html; charset=UTF-8
Location: https://portal.azure.com/#cloudshell/
Server: Microsoft-IIS/10.0
X-Powered-By: ASP.NET
Date: Fri, 12 Mar 2021 10:40:34 GMT
<head><title>Document Moved</title></head>
<body><h1>Object Moved</h1>This document may be found <a HREF="https://portal.azure.com/#cloudshell/">here</a></body>
So there is no need to use https://shell.azure.com.
The same applies to Azure/azure-powershell#14531.
Member
Author
There was a problem hiding this comment.
The trailing slash (/) is against the URL syntax:
The following are two example URIs and their component parts:
foo://example.com:8042/over/there?name=ferret#nose
\_/ \______________/\_________/ \_________/ \__/
| | | | |
scheme authority path query fragment
| _____________________|__
/ \ / \
urn:example:animal:ferret:nose
So remove it.
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
evelyn-ys
approved these changes
Mar 16, 2021
Juliehzl
approved these changes
Mar 16, 2021
fengzhou-msft
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Cloud Shell icon image https://shell.azure.com/images/launchcloudshell.png is no longer available, making the link unclickable:
Changes
Borrow new contents from Azure/azure-powershell#13969 and https://docs.microsoft.com/en-us/azure/cloud-shell/overview