Skip to content

{Monitor} az monitor metrics alert update: fix update action issue #17289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 1 commit into from
Mar 17, 2021
Merged

{Monitor} az monitor metrics alert update: fix update action issue #17289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions src/azure-cli/azure/cli/command_modules/monitor/operations/metric_alert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,9 @@ def update_metric_alert(instance, scopes=None, description=None, enabled=None, t

# process action additions
if add_actions is not None:
for action in add_actions:
match = next(
(x for x in instance.actions if action.action_group_id.lower() == x.action_group_id.lower()), None
)
if match:
match.webhook_properties = action.webhook_properties
else:
instance.actions.append(action)
add_action_ids = {x.action_group_id.lower() for x in add_actions}
instance.actions = [x for x in instance.actions if x.action_group_id.lower() not in add_action_ids]
instance.actions.extend(add_actions)

@jsntcy jsntcy Mar 17, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use match for webhook_properties now? What does this change mean?

@kairu-ms kairu-ms Mar 17, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 'add_actions', the logical of original code is that if that action already exist then update its properties. Now I change the logic, if that action already exist, remove the old one and add the new one.


# process condition removals
if remove_conditions is not None:
Expand Down
Loading