Skip to content

[Storage] Fix #16979: az storage container create fails when providing storage container metadata #17202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evelyn-ys merged 11 commits into from
Mar 17, 2021
Merged

[Storage] Fix #16979: az storage container create fails when providing storage container metadata #17202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ed544b2
add rdbms code owner
evelyn-ys Dec 29, 2020
ab56be3
Merge remote-tracking branch 'upstream/dev' into dev
evelyn-ys Jan 4, 2021
4a2d336
Merge remote-tracking branch 'upstream/dev' into dev
evelyn-ys Jan 5, 2021
de9c11f
Merge remote-tracking branch 'upstream/dev' into dev
evelyn-ys Jan 8, 2021
114d94b
Merge remote-tracking branch 'upstream/dev' into dev
evelyn-ys Jan 12, 2021
0c805be
Merge remote-tracking branch 'upstream/dev' into dev
evelyn-ys Feb 18, 2021
c8ec7ac
Merge remote-tracking branch 'upstream/dev' into dev
evelyn-ys Mar 2, 2021
9367a8b
Merge remote-tracking branch 'upstream/dev' into dev
evelyn-ys Mar 3, 2021
76dcf95
validate metadata
evelyn-ys Mar 4, 2021
477d4e3
tests
evelyn-ys Mar 10, 2021
916168f
test record
evelyn-ys Mar 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/azure-cli/azure/cli/command_modules/storage/_validators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1368,6 +1368,7 @@ def validate_client_auth_parameter(cmd, ns):
"when creating container.")
else:
validate_client_parameters(cmd, ns)
validate_metadata(ns)


def validate_encryption_scope_client_params(ns):
Expand Down
93 changes: 48 additions & 45 deletions src/azure-cli/azure/cli/command_modules/storage/tests/latest/recordings/test_legal_hold.yaml
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion ...e-cli/azure/cli/command_modules/storage/tests/latest/test_storage_container_legal_hold.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def test_legal_hold(self, resource_group):
self.cmd('storage account create -g {} -n {} --kind StorageV2'.format(
resource_group, storage_account))
container_name = 'container1'
self.cmd('storage container create --account-name {} -n {}'.format(storage_account, container_name))
self.cmd('storage container create --account-name {} -n {} --metadata k1=v1 k2=v2'.format(storage_account, container_name))

self.cmd('storage container legal-hold show --account-name {} -c {} -g {}'.format(
storage_account, container_name, resource_group), checks=[
Expand Down