[KeyVault] BREAKING CHANGE: id changes to be jobId, azureStorageBlobContainerUri changes to be folderUrl in command output of az keyvault backup/restore, az keyvault key restore#17011
Conversation
|
|
| with self.argument_context('keyvault key restore', arg_group='Restoring keys from storage account') as c: | ||
| c.argument('token', options_list=['--storage-container-SAS-token', '-t'], | ||
| help='The SAS token pointing to an Azure Blob storage container') | ||
| c.argument('backup_folder', help='Name of the blob container which contains the backup') |
There was a problem hiding this comment.
we need to sync with SDK team to understand why the breaking change. this IS a breaking change to CLI users. thanks for the email.
There was a problem hiding this comment.
how about we keep this param in CLI for a while with deprecation message, explain it will be auto retrieved from storage-resource-uri in future, the param itself just do nothing.
There was a problem hiding this comment.
I sent back an email a little while ago, but to make sure I state it here: there don't need to be any breaking changes in the CLI, if you don't think it makes sense to introduce any. The SDK now accepts a backup_storage_url that's a concatenation of what used to be provided as backup_storage_uri and folder_name, but this full URL can be generated by the CLI. This is the PR where the change was made on the SDK's side, for reference.
|
Need run live test for full_restore and selective_key_restore |
--backup-folder parameter from az keyvault restore start and az keyvault key restore startid changes to be jobId, azureStorageBlobContainerUri changes to be folderUrl in command az keyvault backup start, az keyvault restore start, az keyvault key restore
id changes to be jobId, azureStorageBlobContainerUri changes to be folderUrl in command az keyvault backup start, az keyvault restore start, az keyvault key restoreid changes to be jobId, azureStorageBlobContainerUri changes to be folderUrl in command output az keyvault backup start, az keyvault restore start, az keyvault key restore
id changes to be jobId, azureStorageBlobContainerUri changes to be folderUrl in command output az keyvault backup start, az keyvault restore start, az keyvault key restoreid changes to be jobId, azureStorageBlobContainerUri changes to be folderUrl in command output of az keyvault backup start, az keyvault restore start, az keyvault key restore
id changes to be jobId, azureStorageBlobContainerUri changes to be folderUrl in command output of az keyvault backup start, az keyvault restore start, az keyvault key restoreid changes to be jobId, azureStorageBlobContainerUri changes to be folderUrl in command output of az keyvault backup/restore start, az keyvault key restore
id changes to be jobId, azureStorageBlobContainerUri changes to be folderUrl in command output of az keyvault backup/restore start, az keyvault key restoreid changes to be jobId, azureStorageBlobContainerUri changes to be folderUrl in command output of az keyvault backup/restore, az keyvault key restore
|
Locally runned live test on full_restore and selective_key_restore related scenario tests. |
Description
This PR bumps the
azure-keyvault-administrationversion to4.0.0b3, so that we can support keyvault role definition feature later.The SDK
azure-keyvault-administration==4.0.0b3brings many breaking changes, see more details on pypi. Among these breaking changes, some of them only resulting in CLI internal changes, but others make AzureCLI introduce breaking changes too.In summary, the breaking changes for end users are:
az keyvault backup start:azure_storage_blob_container_uriproperty changes to befolder_urlin command outputaz keyvault backup start,az keyvault restore start,az keyvault key restore:idproperty changes to bejob_idin command outputTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.