[HDInsight]Support compute isolation and return private ip address #16752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Collaborator
|
@kairu-ms to help with this PR. |
kairu-ms
reviewed
Feb 2, 2021
| c.argument('enable_compute_isolation', options_list=['--enable-compute-isolation', '--compute-isolation'], | ||
| arg_group="Compute Isolation", arg_type=get_three_state_flag(), | ||
| help='Indicate whether enable compute isolation or not.') | ||
| c.argument('host_sku', arg_group='Compute Isolation', help="The dedicated host sku of compute isolation.") |
Member
Author
There was a problem hiding this comment.
Is it an enum argument?
It is a string.
| @staticmethod | ||
| def _with_compute_isolation(): | ||
| return '--version 3.6 -l southcentralus ' \ | ||
| '--enable-compute-isolation --workernode-size Standard_E8S_V3 --headnode-size Standard_E8S_V3' |
Contributor
There was a problem hiding this comment.
Can you provide any test with --host-sku argument
Member
Author
There was a problem hiding this comment.
Can you provide any test with --host-sku argument
Sure, currently we do not need to provide this parameter, backend will provide a default value for this.
Anyway, I will update the related test case. Thanks.
…andatory for creating cluster
kairu-ms
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The related swagger spec PR is Azure/azure-rest-api-specs#12612
Testing Guide
--enable-compute-isolationis the new added parameter when creating cluster, the above command will create a cluster with compute isolation feature.History Notes
[HDInsight]
az hdinsight create: Add a new parameter--enable-compute-isolationto support create cluster with compute isolation feature.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.