[KeyVault] az keyvault key import: Support --curve parameter for importing BYOK keys#16593
Conversation
houk-ms
changed the title
--curve parameter in az keyvault key importaz keyvault key import: Support --curve parameter for importing BYOK keys
yungezz
reviewed
Jan 20, 2021
src/azure-cli/azure/cli/command_modules/keyvault/_validators.py
Outdated
Show resolved
Hide resolved
yungezz
approved these changes
Jan 20, 2021
Co-authored-by: Yunge Zhu <yungez@microsoft.com>
qwordy
reviewed
Jan 20, 2021
| kty = getattr(ns, 'kty', None) | ||
| crv = getattr(ns, 'curve', None) | ||
|
|
||
| if (kty == 'EC' and crv is None) or (kty != 'EC' and crv): |
Contributor
Author
There was a problem hiding this comment.
We don't accept the lower case, it also applies to other existing commands.
qwordy
approved these changes
Jan 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing Guide
This PR fixes https://github.com/Azure/azure-cli-pr/issues/121
It provides the
--curveparamter inaz keyvault key importcommand.The command below could be used for key importing after the fix.
The behavior of
--ktyand--curveparamters.--ktyhas the default valueRSA--curveshould be specified together with--kty ECHistory Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.