{Monitor} Migrate monitor to track2#16551
Merged
Conversation
jsntcy
requested review from
Juliehzl,
aim-for-better,
evelyn-ys,
fengzhou-msft,
houk-ms,
jaredmoo,
jiasli,
kairu-ms,
msyyc,
qwordy,
yungezz and
zhoxing-ms
as code owners
Collaborator
|
Monitor |
Member
|
VM part looks good to me. |
qwordy
approved these changes
Jan 18, 2021
jsntcy
force-pushed
the
migrate-monitor-track2
branch
from
8c6d420 to
8de7f81
Compare
kairu-ms
reviewed
Jan 18, 2021
Comment on lines
-346
to
+345
Contributor
There was a problem hiding this comment.
Why did your remove the validator for receivers?
Member
Author
There was a problem hiding this comment.
Move it to g.command('create', 'create_or_update', table_transformer=action_group_list_table, validator=process_action_group_detail_for_creation) now, because :
- The validator validates not only
receivers, but also other arguments. - I need use command validator (
process_action_group_detail_for_creation) to overwrite argument validator (validate_tags) asvalidate_tagsshould not used for this command asprocess_action_group_detail_for_creationdefines its own_validate_tags.
In reply to: 559287114 [](ancestors = 559287114)
jsntcy
force-pushed
the
migrate-monitor-track2
branch
from
8de7f81 to
5653588
Compare
kairu-ms
approved these changes
Jan 18, 2021
jsntcy
force-pushed
the
migrate-monitor-track2
branch
from
dc2cb17 to
83d8d17
Compare
Member
|
@jsntcy Can you help summarize common code changes in this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate monitor to track2
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.