Conversation
Member
Author
|
Hi @shenmuxiaosen, could you help review this change? |
Member
|
hi @qwordy could you pls help to review? |
src/azure-cli/azure/cli/command_modules/appconfig/_validators.py
Outdated
Show resolved
Hide resolved
qwordy
approved these changes
Jan 18, 2021
Member
|
It is not easy to input JSON. |
|
When is this new feature expected to be released? Was it included in today's release? |
Member
Author
|
Hi @MarshallMoorman, this feature did not make it in today's release. It will be included in the next release. You can refer to the release notes to see which CLI version will contain this release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #16374
Affected Command:
Az appconfig feature filter add -n TestAppConfig --feature Beta –filter-name TestFilter --filter-parameters name1=value1 name2=value2Current Behavior:
Always treat the
valuein--filter-parameters name=valueas string value.New Behavior:
Accept only escaped JSON string as
valuein--filter-parameters name=value, and convert it to the correct data type accordingly.Testing Guide
The following command should fail since the value is not a JSON escaped string:
az appconfig feature filter add -n TestAppConfig --feature Beta --filter-name TestFilter --filter-parameters stringValue=SomeTextThis modified version should pass:
az appconfig feature filter add -n TestAppConfig --feature Beta --filter-name TestFilter --filter-parameters stringValue=\"SomeText\"History Notes
[AppConfig] BREAKING CHANGE: az appconfig feature filter add:
valuein--filter-parameters name=valuenamecannot be empty in--filter-parameters name=value--filter-parameters stringValue=\"This is some text\"--filter-parameters numberValue=75--filter-parameters arrayValue=[1,2,3]--filter-parameters boolValue=true--filter-parameters objectValue={\"Test\":{\"Level\":\"Debug\"}}This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.