[ARM] ts: error handling improvement - use of --template-file without --version prohibited#16446
Merged
zhoxing-ms merged 5 commits intoAzure:devfrom Jan 13, 2021
detienne20:ts-create-tf-version-bug
Merged
[ARM] ts: error handling improvement - use of --template-file without --version prohibited#16446zhoxing-ms merged 5 commits intoAzure:devfrom detienne20:ts-create-tf-version-bug
zhoxing-ms merged 5 commits intoAzure:devfrom
detienne20:ts-create-tf-version-bug
Conversation
Collaborator
|
ARM |
added 2 commits
January 11, 2021 08:13
zhoxing-ms
approved these changes
Jan 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug found: az ts create does not update the template pec content when the version is not specified and no useful error message or warning is shown to specify --version is required.
This PR addresses this bug by throwing an incorrect usage error when --template-file is provided without the --version parameter present.
Testing Guide
az ts create --name TemplateSpecName --resource-group ResourceGroupName --template-file "azuredeploy.json" should result in incorrect usage error.