Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Dec 29, 2020

Description
As we are bumping to 3.0.0 for Azure Identity Integration, several arguments will stop working since 3.0.0 and cause many CI failures.

_____ BotTests.test_prepare_publish_with_unregistered_bot_name_should_fail _____
...
----------------------------- Captured stderr call -----------------------------
RequiredArgumentMissingError: the following arguments are required: --proj-file-path
------------------------------ Captured log call -------------------------------
ERROR    cli.azure.cli.core.azclierror:azclierror.py:55 RequiredArgumentMissingError: the following arguments are required: --proj-file-path

This draft PR aims to assist command module owners to resolve these expirations by

  1. Removing expiration if no explicit deprecation plan is provided.
  2. Setting expiration to higher versions like 4.0.0, but the release plan of 4.0.0 is undetermined and this issue will occur again when bumping to 4.0.0.

ℹ The regex used to search for the occurrence of expiration is

expiration=['"]3.0.0['"]

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 29, 2020

Resolve expiration='3.0.0'

@yonzhan yonzhan added this to the S181 milestone Dec 29, 2020
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevengum, please kindly take a look at the changes and take action accordingly. Thanks.

@yonzhan yonzhan modified the milestones: S181, S182 Jan 16, 2021
@yonzhan yonzhan modified the milestones: S182, S183 Feb 6, 2021
@yonzhan yonzhan modified the milestones: S183 - For Ignite, S184 Feb 26, 2021
@yonzhan yonzhan modified the milestones: S184, S185 Mar 20, 2021
@yonzhan yonzhan modified the milestones: S185, S186 Apr 10, 2021
@yonzhan yonzhan modified the milestones: S186, S187 May 1, 2021
@yonzhan yonzhan modified the milestones: S187, S188 May 22, 2021
@yonzhan yonzhan modified the milestones: S188, S189 Jun 13, 2021
@yonzhan yonzhan removed this from the S189 milestone Jul 2, 2021
@jiasli jiasli force-pushed the deprecate-expiration branch from d09742f to 636f4e8 Compare October 11, 2021 08:06
@jiasli jiasli changed the title {Misc.} Resolve expiration='3.0.0' {Misc.} Change deprecation expiration to 4.0.0 Oct 11, 2021
@jiasli jiasli marked this pull request as ready for review October 11, 2021 08:06
@jiasli
Copy link
Member Author

jiasli commented Mar 23, 2022

There is no plan to bump Azure CLI to 3.0.0 now, even for Microsoft Graph migration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants