[SQL] az sql dw update: fix update to not accept backup-storage-redundancy; az sql db update: commit storage_account_type updates #16326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xaliciayang
requested review from
Juliehzl,
evelyn-ys and
jaredmoo
as code owners
xaliciayang
changed the title
xaliciayang
changed the title
xaliciayang
changed the title
evelyn-ys
reviewed
Dec 21, 2020
| if _should_show_backup_storage_redundancy_warnings(location): | ||
| if storage_account_type == 'GRS': | ||
| _backup_storage_redundancy_specify_geo_warning() | ||
| print(storage_account_type) |
Member
There was a problem hiding this comment.
Is this for debug? Should we print this to cx?
Contributor
Author
There was a problem hiding this comment.
yeah my bad I'm taking it out ... no need to show customer 👍
evelyn-ys
approved these changes
Dec 21, 2020
Collaborator
|
@Juliehzl please help with this PR. |
yezz123
approved these changes
Dec 22, 2020
3 tasks
Juliehzl
approved these changes
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A previous PR from earlier this year added backup-storage-redundancy to all SQL create/update methods. This inadvertently added the functionality to SQL DW as well. However, this parameter should not be available during dw update (not supported in the backend), so this PR removes the customer's ability to update a DW's backup storage redundancy.
Additionally, this fixes an issue for az sql db update; where the update command was not updating backup storage redundancy values on existing databases.
Testing Guide
History Notes
[SQL] az sql dw update: do not accept backup-storage-redundancy argument
[SQL] az sql db update: update backup storage redundancy as requested from command
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.