{CI} Fix dependency version in setup.py, drop eoan package #16306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengzhou-msft
requested review from
Juliehzl,
evelyn-ys,
haroldrandom,
houk-ms,
jiasli and
jsntcy
as code owners
fengzhou-msft
commented
Dec 17, 2020
| 'azure-appconfiguration~=1.1.1', | ||
| 'azure-batch~=10.0.0', | ||
| 'azure-cli-core=={}.*'.format(VERSION), | ||
| 'azure-cli-core=={}.*'.format(".".join(VERSION.split(".")[:3])), |
Member
Author
There was a problem hiding this comment.
VERSION can be in the format of 2.16.0 or 2.16.0.devN. Both cases will result in azure-cli-core==2.16.0.*.
Member
Author
There was a problem hiding this comment.
It seems 2.16.0.* can match with both 2.16.0 and 2.16.0.devN, but 2.16.0.devN.* cannot match 2.16.0.devN in pip 20.3.
fengzhou-msft
changed the title
haroldrandom
approved these changes
Dec 17, 2020
Collaborator
|
CI |
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pip 20.3 has strict check for dependency versions. In CI the version is modified with a suffix of
devN, this PR modifies the version requirements insetup.pyto make it compatible in this case.Ubuntu Eoanhas reached end-of-life and is dropped in this PR.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.