[SQL] az sql mi create/update: Add support for maintenance configuration in managed instance operations #16229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukislav
requested review from
Juliehzl,
evelyn-ys and
jaredmoo
as code owners
ghost
added
the
customer-reported
|
Thank you for your contribution kukislav! We will review the pull request and get back to you soon. |
|
|
Collaborator
|
SQL |
Contributor
Author
|
I checked the linter pipeline that fails and fixed all issues associated with my command. What should I do about others like this one? |
Contributor
Author
|
This is not customer reported as bot labelled it, this is a new feature. |
Member
This is fixed in #16297. Please merge the latest 'dev' branch into your branch to pass CI |
Contributor
Author
|
@evelyn-ys I have updated code and fixed everything. Please review. |
evelyn-ys
reviewed
Jan 7, 2021
evelyn-ys
reviewed
Jan 7, 2021
src/azure-cli/azure/cli/command_modules/sql/tests/latest/test_sql_commands.py
Outdated
Show resolved
Hide resolved
evelyn-ys
changed the title
evelyn-ys
approved these changes
Jan 28, 2021
Member
evelyn-ys
left a comment
evelyn-ys
left a comment
There was a problem hiding this comment.
Please resolve conflicts before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.