Skip to content

[AppService] Bugfix: Better error handling when trying to create duplicate ASP in diff location#16143

Merged
qwordy merged 2 commits intoAzure:devfrom
calvinsID:webapp-up-error-handling
Dec 25, 2020
Merged

[AppService] Bugfix: Better error handling when trying to create duplicate ASP in diff location#16143
qwordy merged 2 commits intoAzure:devfrom
calvinsID:webapp-up-error-handling

Conversation

@calvinsID
Copy link
Copy Markdown
Contributor

Description
Fixes #16008

When using az webapp up to create an app with existing ASP in a different location, we show the following unhandled error message (notice UnknownError):

image

This PR is to handle the error msg:

image

Testing Guide

  • run az webapp up --location location1 --name name1
  • re-run using different name and location. plan should be defaulted to the same plan created from the first invocation of the command. az webapp up --location location2 --name name2

Should get error message saying ASP exists in different location
cls


This checklist is used to make sure that common guidelines for a pull request are followed.

@panchagnula
Copy link
Copy Markdown
Contributor

so this repros with or without --html flag - I think the reported error was specific to --html parameter used in the command

@panchagnula panchagnula removed the request for review from Kotasudhakarreddy December 4, 2020 02:24
@panchagnula panchagnula added this to the S180 milestone Dec 4, 2020
Copy link
Copy Markdown
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Dec 4, 2020

AppService

@calvinsID calvinsID force-pushed the webapp-up-error-handling branch from 03f26b6 to c81bd82 Compare December 4, 2020 18:58
@qwordy
Copy link
Copy Markdown
Member

qwordy commented Dec 7, 2020

@qwordy
Copy link
Copy Markdown
Member

qwordy commented Dec 23, 2020

Is CLIError allowed? @houk-ms @yungezz

@calvinsID calvinsID force-pushed the webapp-up-error-handling branch from c81bd82 to ab2b308 Compare December 23, 2020 21:31
@qwordy qwordy merged commit cf9a4dc into Azure:dev Dec 25, 2020
@qwordy
Copy link
Copy Markdown
Member

qwordy commented Dec 25, 2020

@calvinsID Thank you for updating error type!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

webapp:az webapp up doesn't work

4 participants