[ACR] bump api version. support zone redundancy#15975
Conversation
|
hi @fengzhou-msft could you pls help to review? |
There was a problem hiding this comment.
pls help to make sure run full live test for regression. :)
There was a problem hiding this comment.
I have re-run tests, please can you review @yungezz
|
@yungezz thanks for the heads up and review. This is a wip pr with the generated sdk. I will remove it when the sdk has been published. I will also make sure to run a full live test locally to ensure no regressions with the new api version. |
5e76392 to
7ad595e
Compare
|
@yungezz @fengzhou-msft please can your review? i am hoping to make next week's code complete. Moreover some acr tests are broken because networking command loading / parameter registration is having issues. I have latest dev. This section in network/_params.py is causing problems: this happens when tests like the one here try to create a vnet: |
|
@jsntcy for awareness. |
As we're migrating network to track2 SDK, hopefully the migration can be done by the end of this week and will check if this issue still exists after migration. |
|
LGTM |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@yungezz please can you reapprove and merge when ready. I am no longer adding the |
955aa71 to
dca81fd
Compare
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.