Skip to content

{Core} Add comments to prevent calling AdalAuthentication._token_retriever #15854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 2 commits into from
Nov 11, 2020
Merged

{Core} Add comments to prevent calling AdalAuthentication._token_retriever #15854

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85ea959
Prevent calling AdalAuthentication._token_retriever
jiasli Nov 10, 2020
2b8c588
Refine
jiasli Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/azure-cli-core/azure/cli/core/adal_authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,12 @@
class AdalAuthentication(Authentication): # pylint: disable=too-few-public-methods

def __init__(self, token_retriever, external_tenant_token_retriever=None):
# DO NOT call _token_retriever from outside azure-cli-core. It is only available for user or
# Service Principal credential (AdalAuthentication), but not for Managed Identity credential
# (MSIAuthenticationWrapper).
# To retrieve a raw token, either call
# - Profile.get_raw_token, which is more direct
# - AdalAuthentication.get_token, which is designed for Track 2 SDKs
self._token_retriever = token_retriever
self._external_tenant_token_retriever = external_tenant_token_retriever

Expand Down