Skip to content

{Error Improvement} Remove error type in error message #15853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
houk-ms wants to merge 2 commits into from
Closed

{Error Improvement} Remove error type in error message #15853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81282e6
remove error type in error message
houk-ms Nov 10, 2020
4f4dacb
fix test
houk-ms Nov 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/azure-cli-core/azure/cli/core/azclierror.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,8 @@ def set_exception_trace(self, exception_trace):
def print_error(self):
from azure.cli.core.azlogging import CommandLoggerContext
with CommandLoggerContext(logger):
# print error type and error message
message = '{}: {}'.format(self.__class__.__name__, self.error_msg)
logger.error(message)
# print the error message
logger.error(self.error_msg)
# print exception trace if there is
if self.exception_trace:
logger.exception(self.exception_trace)
Expand Down
2 changes: 1 addition & 1 deletion src/azure-cli-core/azure/cli/core/tests/test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ def mock_add_extension(*args, **kwargs):
# assert the right type of error msg is logged for command vs argument parsing
self.assertEqual(len(logger_msgs), 5)
for msg in logger_msgs[:3]:
self.assertIn("CommandNotFoundError", msg)
self.assertIn("is misspelled or not recognized by the system", msg)
for msg in logger_msgs[3:]:
self.assertIn("not a valid value for '--opt'.", msg)

Expand Down