[Storage] Migrate from track1 to track2 #15845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsntcy
requested review from
Juliehzl,
evelyn-ys and
zhoxing-ms
as code owners
Collaborator
|
Storage |
jsntcy
requested review from
aim-for-better,
arrownj,
bim-msft,
digimaun,
fengzhou-msft,
haroldrandom,
jaredmoo,
kairu-ms,
msyyc,
qwordy and
yungezz
as code owners
jsntcy
force-pushed
the
upgrade-track2-storage
branch
from
f6355d5 to
f57c5ce
Compare
jsntcy
force-pushed
the
upgrade-track2-storage
branch
from
72fffe7 to
90388c3
Compare
bim-msft
approved these changes
Nov 12, 2020
Juliehzl
reviewed
Nov 12, 2020
| def set_legal_hold(cmd, client, container_name, account_name, tags, resource_group_name=None): | ||
| LegalHold = cmd.get_models('LegalHold', resource_type=ResourceType.MGMT_STORAGE) | ||
| legal_hold = LegalHold(tags=tags) | ||
| return client.set_legal_hold(resource_group_name, account_name, container_name, legal_hold) |
Contributor
There was a problem hiding this comment.
avoid using positional arguments. please fix in next PR.
Member
Author
There was a problem hiding this comment.
Juliehzl
approved these changes
Nov 12, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here are the changes we need do for this migration:
begin_.msrest.exceptions.ClientExceptionwill be replaced withazure.core.exceptions.HttpResponseError;msrestazure.azure_exceptions.CloudErrorwill be replaced withazure.core.exceptions.HttpResponseError.client.configand instead pass them as the parameters for client constructor or pass them in each method call.client.check_name_availability(account_name) // account_name is stringaccount_name = StorageAccountCheckNameAvailabilityParameters(name=name) client.check_name_availability(account_name)azure.mgmt-storageand necessaryimportstatement in patch_models.py to pass CI check.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.