Skip to content

{Core} Use custom tag message #15730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiasli merged 4 commits into from
Dec 17, 2020
Merged

{Core} Use custom tag message #15730

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bd43180
Override preview and experimental message
jiasli Oct 29, 2020
374c698
Unify direct and implicit message
jiasli Oct 30, 2020
afa7bdb
Update message
jiasli Nov 20, 2020
03bdae9
Use status_tag_messages dict
jiasli Dec 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/azure-cli-core/azure/cli/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ def __init__(self, **kwargs):

self.progress_controller = None

_configure_knack()

def refresh_request_id(self):
"""Assign a new random GUID as x-ms-client-request-id

Expand Down Expand Up @@ -851,3 +853,13 @@ def get_default_cli():
logging_cls=AzCliLogging,
output_cls=AzOutputProducer,
help_cls=AzCliHelp)


def _configure_knack():
"""Override consts defined in knack to make them Azure CLI-specific."""
from knack.util import status_tag_messages
ref_message = "Reference and support levels: https://aka.ms/CLI_refstatus"
# Override the preview message
status_tag_messages['preview'] = "{} is in preview and under development. " + ref_message
Copy link
Member

@evelyn-ys evelyn-ys Dec 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
status_tag_messages['preview'] = "{} is in preview and under development. " + ref_message
status_tag_messages['preview'] = "{} is in preview. " + ref_message

I noticed that in knack there's no 'under development' for preview message.

Copy link
Member Author

@jiasli jiasli Dec 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not necessary for Azure CLI and Knack to have the same message. The message I used in this PR has been approved by PMs and UX team.

# Override the experimental message
status_tag_messages['experimental'] = "{} is experimental and under development. " + ref_message