[AppService] Fixes #15604, #15605: Add Dotnet5 support #15721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinsID
force-pushed
the
dotnet5
branch
3 times, most recently
from
72e2f79 to
2a6b2ca
Compare
This was
linked to
issues
Oct 29, 2020
calvinsID
commented
Oct 29, 2020
calvinsID
commented
Oct 29, 2020
Member
|
hi @qwordy could you pls help to review? |
Contributor
Author
|
Still testing, will take PR out of draft when done |
Member
|
OK. Will review after it is done. |
calvinsID
commented
Oct 30, 2020
Member
|
@calvinsID Can you help set the target branch to |
Member
|
@panchagnula I sign-off on my side. Got to test it out with the private drop I got from @calvinsID and everything looks tip-top 🎩 |
calvinsID
changed the title
Contributor
|
@qwordy can you help us with the build errors? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
The failed task can succeed in other PRs. Let's retry. |
Member
|
I wrote a PR to fix it: #15804. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
It is merged. |
… runtime version is different, doesnt update runtime properly
Contributor
Author
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
qwordy
approved these changes
Nov 9, 2020
calvinsID
added a commit
to calvinsID/azure-cli
that referenced
this pull request
Nov 12, 2020
qwordy
pushed a commit
that referenced
this pull request
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15604 #15605
dotnet|5.0can be used withaz webapp createandaz webapp upTesting Guide
az webapp list-runtimes (--linux)should showdotnet|5.0as an available runtimeaz webapp uprun in a .NET5 app should work and create adotnet|5.0webappaz webapp create --runtime "dotnet|5.0"should create adotnet|5.0webappAlso included bugfixes:
az webapp create --runtimenot idempotent #15701: runningaz webapp create --runtime "node|12-lts"consecutively with the same webapp should workaz webapp upon an existing webapp with different runtime doesn't update the webapp's runtimeThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.