Skip to content

Conversation

@jiasli
Copy link
Member

@jiasli jiasli commented Oct 28, 2020

Description

Fix incorrect logic of resource_to_scopes and scopes_to_resource introduced by #15184.

According to Trailing slash and /.default,

  • For some services, the trailing slash should not appear in the resource URI, like https://managedhsm.azure.com, and the corresponding scope should be https://managedhsm.azure.com/.default
  • On the other hand, for some other services, the trailing slash is mandatory, like https://management.azure.com/, and the corresponding scope should be https://management.azure.com//.default - note the double slash!

This PR changes the behavior so that no extra logic is performed on the trailing slash - CLI only appends or strips /.default with no fancy logic.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 28, 2020

Core

@yonzhan yonzhan added this to the S178 milestone Oct 28, 2020
@yonzhan yonzhan requested a review from evelyn-ys October 28, 2020 09:25
Copy link
Contributor

@arrownj arrownj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants